Bump testcontainers to 1.16 #19648
Merged
Bump testcontainers to 1.16 #19648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/dependencies
|
Good catch! Let me double-check locally in Ubuntu WSL and Windows natively... |
famod
approved these changes
Aug 25, 2021
There was a problem hiding this comment.
A lot of duplication in those processors but I guess that could be some refactoring task for later.
What I find very interesting is that with latest Docker Desktop 3.6.0, I cannot run those invoker tests on main anymore (both in WSL2 and Windows natively) because of:
Can not connect to Ryuk at localhost:49156: java.net.ConnectException: Connection refused: connect
I'm pretty sure I wasn't seeing that with 3.5.x.
But with this change, I can run those tests again! So I propose to backport this, ideally even to 2.1 if feasible.
famod
added
the
triage/waiting-for-ci
|
PS: I was surprised When I force-enable that profile on Windows, then the surefire part runs fine, but failsafe hangs very early on. |
|
Thanks for checking! Yup, there is plenty of duplication, but that's the price we pay for dev services. As for backporting, I dunno really... The second commit should likely be backported, but the version bump I don't know ... I'll leave it up to @gsmet to decide |
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 236900a
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 integration-tests/container-image/maven-invoker-way/target/it/container-image-jib-with-redis✖ ⚙️ JVM Tests - JDK 16 #📦 integration-tests/container-image/maven-invoker-way/target/it/container-image-jib-with-redis✖ ⚙️ MicroProfile TCKs Tests #📦 tcks/microprofile-fault-tolerance✖ |
|
The failures are genuine and due to the fact that I mistakenly added a
change to Redis.
I'll update the PR soon
…On Wed, Aug 25, 2021, 19:51 quarkus-bot[bot] ***@***.***> wrote:
Failing Jobs - Building 236900a
<236900a>
Status Name Step Test failures Logs Raw logs
✖ JVM Tests - JDK 11 Build Test failures
<#m_3094285745310865949_user-content-test-failures-job-3422489883> Logs
<https://github.com/quarkusio/quarkus/runs/3422489883?check_suite_focus=true> Raw
logs
<https://github.com/quarkusio/quarkus/commit/236900afc0d1affc07131d430fc5b4c059b1c3c8/checks/3422489883/logs>
✖ JVM Tests - JDK 16 Build Test failures
<#m_3094285745310865949_user-content-test-failures-job-3422489948> Logs
<https://github.com/quarkusio/quarkus/runs/3422489948?check_suite_focus=true> Raw
logs
<https://github.com/quarkusio/quarkus/commit/236900afc0d1affc07131d430fc5b4c059b1c3c8/checks/3422489948/logs>
✖ MicroProfile TCKs Tests Verify Test failures
<#m_3094285745310865949_user-content-test-failures-job-3422490293> Logs
<https://github.com/quarkusio/quarkus/runs/3422490293?check_suite_focus=true> Raw
logs
<https://github.com/quarkusio/quarkus/commit/236900afc0d1affc07131d430fc5b4c059b1c3c8/checks/3422490293/logs>
Full information is available in the Build summary check run
<https://github.com/quarkusio/quarkus/runs/3424467244>.
Test Failures ⚙️ JVM Tests - JDK 11 #
<#m_3094285745310865949_user-content-test-failures-job-3422489883> 📦
integration-tests/container-image/maven-invoker-way/target/it/container-image-jib-with-redis
✖ org.acme.redis.IncrementResourceIT.testRedisOperations - More details
<https://github.com/quarkusio/quarkus/runs/3424467244#user-content-test-failure-org.acme.redis.incrementresourceit-1>
- Source on GitHub
<https://github.com/geoand/quarkus/blob/236900afc0d1affc07131d430fc5b4c059b1c3c8/integration-tests/container-image/maven-invoker-way/target/it/container-image-jib-with-redis/src/test/java/org/acme/redis/IncrementResourceIT.java>
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.redis.client.deployment.DevServicesRedisProcessor#startRedisContainers threw an exception: org.testcontainers.containers.ContainerLaunchException: Container startup failed
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:315)
at io.quarkus.redis.client.deployment.DevServicesRedisProcessor.lambda$startContainer$1(DevServicesRedisProcessor.java:160)
at java.base/java.util.Optional.orElseGet(Optional.java:369)
at io.quarkus.redis.client.deployment.DevServicesRedisProcessor.startContainer(DevServicesRedisProcessor.java:168)
at io.quarkus.redis.client.deployment.DevServicesRedisProcessor.startRedisContainers(DevServicesRedisProcessor.java:90)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invok...
------------------------------
⚙️ JVM Tests - JDK 16 #
<#m_3094285745310865949_user-content-test-failures-job-3422489948> 📦
integration-tests/container-image/maven-invoker-way/target/it/container-image-jib-with-redis
✖ org.acme.redis.IncrementResourceIT.testRedisOperations - More details
<https://github.com/quarkusio/quarkus/runs/3424467244#user-content-test-failure-org.acme.redis.incrementresourceit-1>
- Source on GitHub
<https://github.com/geoand/quarkus/blob/236900afc0d1affc07131d430fc5b4c059b1c3c8/integration-tests/container-image/maven-invoker-way/target/it/container-image-jib-with-redis/src/test/java/org/acme/redis/IncrementResourceIT.java>
java.lang.RuntimeException:
java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
[error]: Build step io.quarkus.redis.client.deployment.DevServicesRedisProcessor#startRedisContainers threw an exception: org.testcontainers.containers.ContainerLaunchException: Container startup failed
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:315)
at io.quarkus.redis.client.deployment.DevServicesRedisProcessor.lambda$startContainer$1(DevServicesRedisProcessor.java:160)
at java.base/java.util.Optional.orElseGet(Optional.java:364)
at io.quarkus.redis.client.deployment.DevServicesRedisProcessor.startContainer(DevServicesRedisProcessor.java:168)
at io.quarkus.redis.client.deployment.DevServicesRedisProcessor.startRedisContainers(DevServicesRedisProcessor.java:90)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invok...
------------------------------
⚙️ MicroProfile TCKs Tests #
<#m_3094285745310865949_user-content-test-failures-job-3422490293> 📦
tcks/microprofile-fault-tolerance
✖
org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead
line 190 - More details
<https://github.com/quarkusio/quarkus/runs/3424467244#user-content-test-failure-org.eclipse.microprofile.fault.tolerance.tck.timeoutuninterruptabletest-1>
- Source on GitHub
<https://github.com/geoand/quarkus/blob/236900afc0d1affc07131d430fc5b4c059b1c3c8/tcks/microprofile-fault-tolerance/src/test/java/org/eclipse/microprofile/fault/tolerance/tck/TimeoutUninterruptableTest.java#L190>
java.lang.AssertionError: Unexpected exception thrown from Future
at org.testng.Assert.fail(Assert.java:85)
at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)
at org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead(TimeoutUninterruptableTest.java:190)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at io.quarkus.arquillian.QuarkusProtocol$QuarkusMethodExecutor$1.invoke(QuarkusProtocol.java:87)
at org.jboss.arquillian.container.test.impl.execution.LocalTestExecuter.execute(LocalTestExecuter.java:57)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19648 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBMDPY6AJOPLIJDMPRQX23T6UNRFANCNFSM5CYV6NWA>
.
|
…tainers This is only applicable for containers running on a shared network. Essentially we now ensure that for containers whose status can only be determined by making a network call, that testcontainers can make that network call. In testcontainers 1.15.x, the library would actually not fail if the connection could not be made, but would essentially give up after a while. With this change, startup of the tests is actually faster since testcontainers actually determines the running status much faster. In 1.16 the behavior seems to have changed and the testcontainers seems to try to launch new containers and never gives up.
Failing Jobs - Building 0e69d68
Full information is available in the Build summary check run. Test Failures⚙️ JVM Tests - JDK 11 #📦 extensions/smallrye-reactive-messaging-kafka/deployment✖ ✖ |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
FTR, this is a general Docker Desktop issue on Windows: docker/for-win#11584 testcontainers 1.16 does try to work around that problem via testcontainers/testcontainers-java#4263 but it's not like nothing works anymore with <1.16, so a backport would be nice but not at all critical. |
8 tasks
dr3s
reviewed
Oct 19, 2021
| <testcontainers.version>1.15.3</testcontainers.version> | ||
| <docker-java.version>3.2.8</docker-java.version> <!-- must be the version Testcontainers use --> | ||
| <testcontainers.version>1.16.0</testcontainers.version> | ||
| <docker-java.version>3.2.11</docker-java.version> <!-- must be the version Testcontainers use --> |
There was a problem hiding this comment.
If you want it to be the version testcontainers uses, consider not specifying it directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #18873
See the first commit for why this works